You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the record, I had a look at the phpstan baseline. Based on the confluence doc I ended up with 3 un-ignorable errors:
Ignored error pattern #^Parameter \#1 \$filename of function file_put_contents expects string, string\|false given\.$# in path src/lib/FieldTypeProcessor/BinaryInputProcessor.php was not matched in reported errors.
Ignored error pattern #^Parameter \#2 \$string of function explode expects string, string\|null given\.$# in path src/lib/Server/Controller/Content.php is expected to occur 1 time, but occurred 4 times.
Ignored error pattern #^Parameter \#1 \$directory of function mkdir expects string, string\|false given\.$# in path tests/lib/FieldTypeProcessor/BinaryInputProcessorTest.php was not matched in reported errors.
How Andrew handled it in 4.6: ibexa/rest#141
Will need to get back to this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Bumped GH action version as old versions will be disabled soon.